Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the set_version and set_variant methods #400

Merged
merged 8 commits into from
Apr 23, 2019
Merged

Conversation

kinggoesgaming
Copy link
Member

I'm submitting a(n) removal

Description

Removes Uuid::set_variant and Uuid::set_version

Motivation

These methods were private and already uuid::builder::Builder was being recommended.

Tests

Current tests should pass.

Related Issue(s)

N/A

@kinggoesgaming kinggoesgaming added this to the 0.8.0 milestone Apr 21, 2019
@kinggoesgaming kinggoesgaming self-assigned this Apr 21, 2019
@kinggoesgaming
Copy link
Member Author

depends on #399

@kinggoesgaming
Copy link
Member Author

Ignore restyled for me

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
src/lib.rs Outdated Show resolved Hide resolved
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@KodrAus
Copy link
Member

KodrAus commented Apr 23, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 23, 2019
400: Remove the set_version and set_variant methods r=KodrAus a=kinggoesgaming

**I'm submitting a(n)** removal

# Description
Removes `Uuid::set_variant` and `Uuid::set_version`

# Motivation
These methods were private and already `uuid::builder::Builder` was being recommended.

# Tests
Current tests should pass.

# Related Issue(s)
N/A

Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 23, 2019

@bors bors bot merged commit 89659c7 into master Apr 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-mut-funs branch April 23, 2019 02:04
bors bot added a commit that referenced this pull request Oct 17, 2019
433: Prepare for 0.8.0 release r=Dylan-DPC a=KodrAus

Closes #431 

[Changeset since the last release](0.7.4...master)

Includes:

- #427 
- #419 
- #424 
- #418 
- #413 
- #407 
- #404 
- #400 
- #399 
- #398 
- #397 
- #396 
- #394 
- #393 
- #390
- #389 
- #388 

I've also added some docs to the 128bit integer methods to clarify how they're different than `to_fields` (for consistency with other uuid libs in the wild).

Co-authored-by: Ashley Mannix <ashleymannix@live.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants