Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "ignore" from code example markup #413

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Removed "ignore" from code example markup #413

merged 2 commits into from
Jun 24, 2019

Conversation

ScholliYT
Copy link
Contributor

@ScholliYT ScholliYT commented Jun 20, 2019

The ignore made the code example non highlighted text. Looks way better with only "```rust"

I'm submitting a(n) bug fix

Description

Added code highlighting for Readme code example.

Motivation

Text looked bad.

The ignore made the code example non highlighted text. Looks way better with only "```rust"
@kinggoesgaming
Copy link
Member

hey @Sawyer47,

Welcome to uuid and thank you for opening this PR.

Can you install cargo-readme and run cargo readme -o README.md. This will ensure the README.md is in sync.

@kinggoesgaming kinggoesgaming self-requested a review June 23, 2019 00:28
Copy link
Member

@kinggoesgaming kinggoesgaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo-readme run

@ScholliYT
Copy link
Contributor Author

Hey,
what do you want me to do?

@kinggoesgaming
Copy link
Member

cargo install cargo-readme
cargo readme -o README.md

And then commit

@kinggoesgaming
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jun 24, 2019
413: Removed "ignore" from code example markup r=kinggoesgaming a=ScholliYT

The ignore made the code example non highlighted text. Looks way better with only "```rust"

**I'm submitting a(n)** bug fix

# Description
Added code highlighting for Readme code example.

# Motivation
Text looked bad.


Co-authored-by: Tom Stein <scholliyt@gmail.com>
Co-authored-by: Scholli <scholliyt@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 24, 2019

@bors bors bot merged commit 72cdede into uuid-rs:master Jun 24, 2019
bors bot added a commit that referenced this pull request Oct 17, 2019
433: Prepare for 0.8.0 release r=Dylan-DPC a=KodrAus

Closes #431 

[Changeset since the last release](0.7.4...master)

Includes:

- #427 
- #419 
- #424 
- #418 
- #413 
- #407 
- #404 
- #400 
- #399 
- #398 
- #397 
- #396 
- #394 
- #393 
- #390
- #389 
- #388 

I've also added some docs to the 128bit integer methods to clarify how they're different than `to_fields` (for consistency with other uuid libs in the wild).

Co-authored-by: Ashley Mannix <ashleymannix@live.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants