Textfield type="password" not working for antd style

[purplecones]

The 'uniforms-antd/TextField does not properly pass the type prop. See below.

For demonstration, I imported both antd and unstyled versions. The antd does not mask the input field as expected.

import AutoForm from 'uniforms-antd/AutoForm';
import TextField from 'uniforms-antd/TextField';
import TextField2 from 'uniforms-unstyled/TextField';

<AutoForm schema={loginFormSchema} onSubmit={submitLogin}>
 <TextField name="email" />
 <TextField name="password" type="password" />
 <TextField2 name="password" type="password" />
 <SubmitField>Submit</SubmitField>
</AutoForm>

[radekmie]

Yep, it's filtered with filterDOMProps. Would you submit a PR for it?

[purplecones]

Looks like the the transpiled files were not updated.

// uniforms-antd/Textfield.js | lines 33 - 45
var Text = function Text(props) {
    return (0, _wrapField2.default)(props, _react2.default.createElement(_input2.default, (0, _extends3.default)({
        disabled: props.disabled,
        id: props.id,
        name: props.name,
        onChange: function onChange(event) {
            return props.onChange(event.target.value);
        },
        placeholder: props.placeholder,
        // missing 'type' prop here 
        ref: props.inputRef, 
        value: props.value
    }, (0, _filterDOMProps2.default)(props))));
};

[radekmie]

Yep, my fault. I've published fixed 1.20.3. Sorry!

[purplecones]

All good now! thanks

[jchristman]

I believe I'm having this same issue in uniforms-material, but I can't for the life of me figure out why. I don't think it's filtered by filterDOMProps based on my reading of the code, but the screenshots below show that it's somehow getting filtered out...

I'm using the following code to generate the form:

import React from 'react';
import Autoform from 'uniforms-material/Autoform';
import TextField from 'uniforms-material/TextField';
import SubmitField from 'uniforms-material/SubmitField';

import { LoginSchema } from '/lib/schemas.js';

const onSubmit = (doc) => {
  Meteor.loginWithPassword(doc.email, doc.password, (err) => {
    if (err !== undefined) {
      console.log(err);
    } else {
      console.log('Login success! Redirect!');
    }
  });
};

const Login = (props) => (
  <div className='login-modal'>
    <Autoform schema={LoginSchema} placeholder={true} label={false} onSubmit={onSubmit}>
      <TextField name='email'/>
      <TextField name='password' type='password'/>
      <SubmitField/>
      <p>Don&apos;t have an account? <a href='/signup'>Register</a></p>
    </Autoform>
  </div>
);

export default Login;

[jchristman]

Thanks for the quick add for that! Much appreciated!

[ziedmahdi]

Hi,

This is may not be the same issue as described above but it's definitely similar.

On https://uniforms.tools if you check the example forms and type something in the password field, the text is shown or it should be hidden.

Is this intentional?

Thank you.

[radekmie]

Hi @ziedmahdi. No, it's not intentional - it's a bug. Thanks for the report, we'll get to it soon.

[alihuber]

Cloud it be that this issue reappeared? This is happening to me with semantic and uniforms-bridge-simple-schema-2, v3.6.1:

Even on the playground it seems to work with JSONSchema, but not SimpleSchema, regardless of the chosen theme.

[wadamek65]

Hi @alihuber ,

Thanks for your comment. It does indeed seem like the same problem is present in simple schema bridges. I've managed to write a test to reproduce this bug and filed an issue for it here: #1039 If you have any other remarks please post them there.