Fix TextField type prop for antd (closes #345) #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I'm not quite sure how I would fully test this locally by importing my version of the library into a sample react app. Right now I'm purely going by the jest test. @radekmie how do you test new changes locally in a react app? |
radekmie
suggested changes
Sep 13, 2017
| @@ -15,6 +15,7 @@ const Text = props => | |||
| placeholder={props.placeholder} | |||
| ref={props.inputRef} | |||
| value={props.value} | |||
| type={props.type} | |||
There was a problem hiding this comment.
Could you keep it ordered?
|
Either by linking it to an existing app (symlink or |
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 156 156
Lines 1301 1301
=====================================
Hits 1301 1301
Continue to review full report at Codecov.
|
radekmie
approved these changes
Sep 14, 2017
|
I'll release it this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #345
@radekmie Let me know if this PR is okay.
I didn't see a need to touch
filterDOMPropsespecially since its being used by all other style versions. It seems it was just a missed prop.