Getting errors on autosave: Can't perform a React state update on an unmounted component....

[michaellill-corefihub]

I'm getting this error in our app when running tests with cypress:

Can't perform a React state update on an unmounted component.
This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in %s.%s", "the componentWillUnmount method", "\n at AutoValidatedQuickBootstrap4Form\n at QuickCheckForm

uniforms/packages/uniforms/src/BaseForm.tsx

Lines 215 to 235 in 49de014

	// Do not call `onSubmit` before componentDidMount
	if (this.mounted && this.props.autosave) {
	if (this.delayId) {
	this.delayId = clearTimeout(this.delayId);
	}
	// Delay autosave by `autosaveDelay` milliseconds...
	this.delayId = setTimeout(() => {
	// ...and wait for all scheduled `setState`s to commit. This is required
	// for AutoForm to validate correct model, waiting in `onChange`.
	this.setState(
	() => null,
	() => {
	this.onSubmit();
	},
	);
	}, this.props.autosaveDelay);
	}
	}

I think we need to check if component is still mounted right before setState in line 226?

[radekmie]

Hi @michaellill-corefihub. Thanks for the report! I think we'd rather clearTimeout it in componentWillUnmount instead.

[michaellill-corefihub]

@radekmie Yes, that is even better.

[michaellill-corefihub]

@radekmie Do you want me to provide a PR?

[radekmie]

I'm already on it, but thanks 😄