Fixed leaking timeout (fixes #920). #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
==========================================
- Coverage 97.48% 97.43% -0.06%
==========================================
Files 202 202
Lines 3890 3892 +2
Branches 779 780 +1
==========================================
Hits 3792 3792
- Misses 10 11 +1
- Partials 88 89 +1
Continue to review full report at Codecov.
|
wadamek65
previously approved these changes
Apr 6, 2021
wadamek65
approved these changes
Apr 7, 2021
Monteth
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #920, the autosave timeout was not cleared on unmount. This PR fixes that as well as corrects the tests.