Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen4: Derived tables #8491

Merged
merged 37 commits into from
Jul 28, 2021
Merged

gen4: Derived tables #8491

merged 37 commits into from
Jul 28, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Jul 19, 2021 •
edited
Loading

Description

Adds support for derived tables in gen4.

Related Issue(s)

#7280

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

systay and others added 2 commits July 19, 2021 08:11
@systay
do table binding when coming up instead of when going down
cadf78c 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@GuptaManan100
added type information in the analyzer
716d617 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
GuptaManan100 and others added 7 commits July 20, 2021 12:20
@GuptaManan100
call interface DepsFor
4a3ea92 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
unexport DepsFor local function
bbaec51 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
use TypeFor from the semantic table in the planbuilder
6e2c08f 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100
added analysis for expressions coming from derived tables
2a719ff 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@systay
added first test of derived tables as operator
15cfedc 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
more operator support for derived tables
c778e32 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
first derived table test that passes plan_test for gen4
2a51552 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Merge branch main into gen4-derived
369075b 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jul 20, 2021
@systay
fix bad merge and test comments
7258ad3 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
more work on derived tables
4f7e45c 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Merge branch main into gen4-derived
299bf18 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay marked this pull request as ready for review July 22, 2021 14:24
@systay
goto is considered harmful
b730c5c 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
fixed test assertions
109c08b 
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
frouioui approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request looks good to me, I have left a couple of comments

go/vt/vtgate/planbuilder/jointree.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/jointree.go Outdated Show resolved Hide resolved
@systay systay marked this pull request as draft July 22, 2021 23:02
@systay
add expressions to derived tables
1e48dd1 
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay and others added 4 commits July 26, 2021 13:44
@systay
Merge branch main into gen4-derived
558deea 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Small refactor
16d65e0 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Added expectations for cases that were already passing
b626fcc 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@frouioui
Avoiding duplicated columns when pushing projection on route plans
a830e0c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Addition of unit test for checkIfAlreadyExists
a9b03af 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as ready for review July 27, 2021 08:06
@frouioui
More readable horizon planning unit test
4cbd5bb 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Clean up unrequired return argument
7dfe516 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui and others added 2 commits July 27, 2021 14:23
@frouioui
Included Derived to the Operator documentation comment
db656cf 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@systay
Make sure to keep derived table aliases around
20cb949 
Signed-off-by: Andres Taylor <andres@planetscale.com>
GuptaManan100
GuptaManan100 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🏎️

@systay
fail aggregation inside of derived tables
7d879df 
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay and others added 3 commits July 28, 2021 10:16
@systay
Merge main into gen4-derived
be4c0b6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
fix formatting error
16cd198 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
code refactor
6d89d0f 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@frouioui
Addition of comment in transformToLogicalPlan to explain the derived …
8d17e60 
…tree transformation

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@systay systay merged commit f3c7a2c into vitessio:main Jul 28, 2021
@systay systay deleted the gen4-derived branch July 28, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@rafael rafael Awaiting requested review from rafael

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@systay @harshit-gangal @frouioui @GuptaManan100