Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen4: Derived tables #8491

Merged
merged 37 commits into from
Jul 28, 2021
Merged

gen4: Derived tables #8491

merged 37 commits into from
Jul 28, 2021

Commits on Jul 19, 2021

  1. do table binding when coming up instead of when going down 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    cadf78c View commit details
    Browse the repository at this point in the history

  2. added type information in the analyzer 

    Signed-off-by: GuptaManan100 <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    716d617 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. call interface DepsFor 

    Signed-off-by: GuptaManan100 <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    4a3ea92 View commit details
    Browse the repository at this point in the history

  2. unexport DepsFor local function 

    Signed-off-by: GuptaManan100 <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    bbaec51 View commit details
    Browse the repository at this point in the history

  3. use TypeFor from the semantic table in the planbuilder 

    Signed-off-by: GuptaManan100 <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    6e2c08f View commit details
    Browse the repository at this point in the history

  4. added analysis for expressions coming from derived tables 

    Signed-off-by: GuptaManan100 <manan@planetscale.com>
    @GuptaManan100
    GuptaManan100 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    2a719ff View commit details
    Browse the repository at this point in the history

  5. added first test of derived tables as operator 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    15cfedc View commit details
    Browse the repository at this point in the history

  6. more operator support for derived tables 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    c778e32 View commit details
    Browse the repository at this point in the history

  7. first derived table test that passes plan_test for gen4 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    2a51552 View commit details
    Browse the repository at this point in the history

  8. Merge branch main into gen4-derived 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    369075b View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. fix bad merge and test comments 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    7258ad3 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. more work on derived tables 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    4f7e45c View commit details
    Browse the repository at this point in the history

  2. Merge branch main into gen4-derived 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    299bf18 View commit details
    Browse the repository at this point in the history

  3. goto is considered harmful 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    b730c5c View commit details
    Browse the repository at this point in the history

  4. fixed test assertions 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    109c08b View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. add expressions to derived tables 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    1e48dd1 View commit details
    Browse the repository at this point in the history

  2. Support for duplicated field name error in derived tables 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2a00621 View commit details
    Browse the repository at this point in the history

  3. Fixed cloning issue with derivedPlan's inner field 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    919c063 View commit details
    Browse the repository at this point in the history

  4. Changing jointree type declaration and visitRelations method 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    6064b23 View commit details
    Browse the repository at this point in the history

  5. Better error handling in joinTree findOutputColumn 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    054c1a7 View commit details
    Browse the repository at this point in the history

  6. Initial support for Derived's push predicates 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    d177438 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Keep track of recursived and normal expr dependencies in the analyzer… 

    … and the semTable

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    d5f68cd View commit details
    Browse the repository at this point in the history

  2. Cleaned up naming and imbricated indentations in the analyzer 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    fb9d1b0 View commit details
    Browse the repository at this point in the history

  3. Merge branch main into gen4-derived 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    558deea View commit details
    Browse the repository at this point in the history

  4. Small refactor 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    16d65e0 View commit details
    Browse the repository at this point in the history

  5. Added expectations for cases that were already passing 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    b626fcc View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Avoiding duplicated columns when pushing projection on route plans 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a830e0c View commit details
    Browse the repository at this point in the history

  2. Addition of unit test for checkIfAlreadyExists 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a9b03af View commit details
    Browse the repository at this point in the history

  3. More readable horizon planning unit test 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    4cbd5bb View commit details
    Browse the repository at this point in the history

  4. Clean up unrequired return argument 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    7dfe516 View commit details
    Browse the repository at this point in the history

  5. Included Derived to the Operator documentation comment 

    Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    db656cf View commit details
    Browse the repository at this point in the history

  6. Make sure to keep derived table aliases around 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    20cb949 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. fail aggregation inside of derived tables 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    7d879df View commit details
    Browse the repository at this point in the history

  2. Merge main into gen4-derived 

    Signed-off-by: Andres Taylor <andres@planetscale.com>
    @systay
    systay committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    be4c0b6 View commit details
    Browse the repository at this point in the history

  3. fix formatting error 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    16cd198 View commit details
    Browse the repository at this point in the history

  4. code refactor 

    Signed-off-by: Harshit Gangal <harshit@planetscale.com>
    @harshit-gangal
    harshit-gangal committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6d89d0f View commit details
    Browse the repository at this point in the history

  5. Addition of comment in transformToLogicalPlan to explain the derived … 

    …tree transformation

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
    @frouioui
    frouioui committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8d17e60 View commit details
    Browse the repository at this point in the history