fix: "All Android Release Notes" item is not clickable [WPB-10125] #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saleniuk
requested review from
a team,
typfel,
yamilmedina,
mchenani,
Garzas and
ohassine
and removed request for
a team
|
saleniuk
changed the title
saleniuk
changed the title
|
Built wire-android-staging-compat-pr-3187.apk is available for download |
|
Built wire-android-dev-debug-pr-3187.apk is available for download |
yamilmedina
approved these changes
Jul 16, 2024
MohamadJaara
changed the title
MohamadJaara
changed the title
MohamadJaara
approved these changes
Jul 17, 2024
|
@saleniuk i checked the smoke tests and it fails for unrelated reason to the changes in this PR it is safe to be merged |
echoes-hq
bot
added
the
echoes: throughput
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
"All Android Release Notes" item on "What's new" screen is not clickable.
Solutions
Added key to
rememberto updateClickableto be enabled for items after loading.Added this "All Android Release Notes" item with different id for the placeholder so that it doesn't jump to the bottom after loading is finished.
Handled errors when fetching or parsing RSS feed simply by returning empty release notes list.
Fixed clickable area for
RowItemso that even if any padding is applied, the click indication will always be shown for the whole row.Also, fixed
DependenciesScreento be annotated with new@WireDestinationinstead of@Destination.Testing
How to Test
Open "What's new" section and try to click on "All Android Release Notes".
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.