Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "All Android Release Notes" item is not clickable - 🍒 v4.7 [WPB-10125] #3214

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jul 22, 2024

BugWPB-10125 [Android] "All Android Release notes" under Android Release notes not clickable on graphene


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Manual cherry-pick for v4.7 of this one: #3187

Issues

"All Android Release Notes" item on "What's new" screen is not clickable.

Solutions

Added key to remember to update Clickable to be enabled for items after loading.
Added this "All Android Release Notes" item with different id for the placeholder so that it doesn't jump to the bottom after loading is finished.
Handled errors when fetching or parsing RSS feed simply by returning empty release notes list.
Fixed clickable area for RowItem so that even if any padding is applied, the click indication will always be shown for the whole row.
Also, fixed DependenciesScreen to be annotated with new @WireDestination instead of @Destination.

Testing

How to Test

Open "What's new" section and try to click on "All Android Release Notes".


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Jul 22, 2024

@saleniuk saleniuk requested review from a team, typfel, yamilmedina, alexandreferris, MohamadJaara and mchenani and removed request for a team July 22, 2024 11:57
Copy link
Contributor

Test Results

945 tests   945 ✅  11m 31s ⏱️
126 suites    0 💤
126 files      0 ❌

Results for commit 8d6c9d6.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk merged commit 1febd6b into release/cycle-4.7 Jul 22, 2024
15 of 16 checks passed
@saleniuk saleniuk deleted the fix/all-release-notes-not-clickable-v4.7 branch July 22, 2024 13:31
@echoes-hq echoes-hq bot added echoes: throughput Changes intended at preserving our ability to evolve the software safely and effectively echoes: bugs Technical or functional defects in the product labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product echoes: throughput Changes intended at preserving our ability to evolve the software safely and effectively size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants