Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit bundles for subconversations #2932

Merged
merged 16 commits into from
Dec 19, 2022
Merged

Commit bundles for subconversations #2932

merged 16 commits into from
Dec 19, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Dec 16, 2022 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 13:14 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 13:14 — with GitHub Actions Inactive
@pcapriotti pcapriotti marked this pull request as draft December 16, 2022 13:14
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 16, 2022
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 13:16 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 13:16 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 13:22 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 13:22 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic self-requested a review December 16, 2022 13:22
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 13:27 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 13:27 — with GitHub Actions Inactive
@pcapriotti pcapriotti changed the base branch from develop to mls December 16, 2022 13:28
mdimjasevic
mdimjasevic approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

services/galley/src/Galley/API/MLS/GroupInfo.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/MLS/SubConversation.hs Show resolved Hide resolved
@pcapriotti pcapriotti marked this pull request as ready for review December 16, 2022 14:39
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 14:40 — with GitHub Actions Inactive
@pcapriotti pcapriotti temporarily deployed to cachix December 16, 2022 14:40 — with GitHub Actions Inactive
elland
elland reviewed Dec 19, 2022
View reviewed changes
services/galley/src/Galley/API/MLS/Conversation.hs
mcMembers = cm
}

mcConv :: MLSConversation -> Data.Conversation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm finding the name of this function hard to parse. Maybe something a bit more descriptive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name hasn't changed, it just used to be a field before.

@pcapriotti pcapriotti merged commit aaa6452 into mls Dec 19, 2022
@pcapriotti pcapriotti deleted the fs-901/commit-bundles branch December 19, 2022 09:18
@stefanwire stefanwire mentioned this pull request Jan 17, 2023
Merged
9 tasks
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elland elland elland left review comments

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pcapriotti @elland @mdimjasevic @zebot @smatting