-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit bundles for subconversations #2932
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
da44964
Add subconversation group info endpoint (wip, untested)
smatting 842d726
Fill implemention holes
smatting 7b4d6ac
refactor clientmap and add TODO for check
smatting c0dd810
Throw when a client is not in the parent conv
mdimjasevic 3881d9d
Remove duplication in MLSConversation type
pcapriotti 0c1e64a
Refactor: Introduce incrementEpoch
smatting a4cada3
Refactor: unqualify parent in SubConversation type
smatting 746feda
add test wip
smatting ed4b3e3
Bump mls-test-cli
pcapriotti f2298b3
Store group info bundle for subconvs
pcapriotti e9d7de5
Fix epoch increment query for subconvs
pcapriotti 9406949
Add join subconversation test
pcapriotti 1de2add
Turn TODO into FUTUREWORK
pcapriotti 5d5ef40
Add stubs of more subconversation tests
pcapriotti dd901ec
Add CHANGELOG entries
pcapriotti be4fe64
Deduplicate function to fetch remote group info
pcapriotti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add `GET /conversations/:domain/:cid/subconversations/:id/groupinfo` endpoint to fetch the group info object for a subconversation |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add support for subconversations in `POST /mls/commit-bundles` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
-- This file is part of the Wire Server implementation. | ||
-- | ||
-- Copyright (C) 2022 Wire Swiss GmbH <opensource@wire.com> | ||
-- | ||
-- This program is free software: you can redistribute it and/or modify it under | ||
-- the terms of the GNU Affero General Public License as published by the Free | ||
-- Software Foundation, either version 3 of the License, or (at your option) any | ||
-- later version. | ||
-- | ||
-- This program is distributed in the hope that it will be useful, but WITHOUT | ||
-- ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS | ||
-- FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more | ||
-- details. | ||
-- | ||
-- You should have received a copy of the GNU Affero General Public License along | ||
-- with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
||
module Galley.API.MLS.Conversation | ||
( mkMLSConversation, | ||
mcConv, | ||
) | ||
where | ||
|
||
import Galley.API.MLS.Types | ||
import Galley.Data.Conversation.Types as Data | ||
import Galley.Effects.MemberStore | ||
import Imports | ||
import Polysemy | ||
import Wire.API.Conversation.Protocol | ||
|
||
mkMLSConversation :: | ||
Member MemberStore r => | ||
Data.Conversation -> | ||
Sem r (Maybe MLSConversation) | ||
mkMLSConversation conv = | ||
for (Data.mlsMetadata conv) $ \mlsData -> do | ||
cm <- lookupMLSClients (cnvmlsGroupId mlsData) | ||
pure | ||
MLSConversation | ||
{ mcId = Data.convId conv, | ||
mcMetadata = Data.convMetadata conv, | ||
mcLocalMembers = Data.convLocalMembers conv, | ||
mcRemoteMembers = Data.convRemoteMembers conv, | ||
mcMLSData = mlsData, | ||
mcMembers = cm | ||
} | ||
|
||
mcConv :: MLSConversation -> Data.Conversation | ||
mcConv mlsConv = | ||
Data.Conversation | ||
{ convId = mcId mlsConv, | ||
convLocalMembers = mcLocalMembers mlsConv, | ||
convRemoteMembers = mcRemoteMembers mlsConv, | ||
convDeleted = False, | ||
convMetadata = mcMetadata mlsConv, | ||
convProtocol = ProtocolMLS (mcMLSData mlsConv) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm finding the name of this function hard to parse. Maybe something a bit more descriptive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name hasn't changed, it just used to be a field before.