Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(torii): make select block cancel safe #2378

Closed
wants to merge 1 commit into from

Conversation

lambda-0x
Copy link
Collaborator

@lambda-0x lambda-0x commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 16.84211% with 79 lines in your changes missing coverage. Please review.

Project coverage is 68.15%. Comparing base (35bc012) to head (0bb0652).

Files with missing lines Patch % Lines
crates/torii/core/src/engine.rs 14.13% 79 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           spr/main/72f22f88    #2378      +/-   ##
=====================================================
- Coverage              68.18%   68.15%   -0.03%     
=====================================================
  Files                    357      357              
  Lines                  47134    47143       +9     
=====================================================
- Hits                   32136    32129       -7     
- Misses                 14998    15014      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambda-0x
Copy link
Collaborator Author

✓ Commit merged in pull request #2381

@lambda-0x lambda-0x closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants