Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt(torii): avoid re-processing of transactions in certain case #2381

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

lambda-0x
Copy link
Collaborator

@lambda-0x lambda-0x commented Sep 3, 2024

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 45.83333% with 117 lines in your changes missing coverage. Please review.

Project coverage is 68.30%. Comparing base (da96b12) to head (04e8950).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/core/src/engine.rs 30.00% 98 Missing ⚠️
crates/torii/core/src/sql.rs 68.18% 14 Missing ⚠️
bin/torii/src/main.rs 0.00% 4 Missing ⚠️
crates/torii/grpc/src/server/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2381      +/-   ##
==========================================
+ Coverage   68.16%   68.30%   +0.13%     
==========================================
  Files         358      357       -1     
  Lines       47128    47181      +53     
==========================================
+ Hits        32123    32225     +102     
+ Misses      15005    14956      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't have this in only one tx hash, let's move forward with it at the moment. We may have this anyway being refactored with switching to getEvent more generally.

@lambda-0x lambda-0x changed the base branch from spr/main/b6db4cb5 to spr/main/8fbc8e6d September 5, 2024 09:29
@lambda-0x lambda-0x changed the base branch from spr/main/8fbc8e6d to main September 5, 2024 09:53
@lambda-0x lambda-0x merged commit c5665d9 into main Sep 5, 2024
27 of 28 checks passed
@lambda-0x lambda-0x deleted the spr/main/a510b985 branch September 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize sync_pending to avoid re-fetching transactions without world events
3 participants