Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt(torii): fetch receipts along with blocks instead of fetching them individually #2380

Closed
wants to merge 1 commit into from

Conversation

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 68.32%. Comparing base (d8ab387) to head (8c6b5d0).

Files with missing lines Patch % Lines
crates/torii/core/src/engine.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           spr/main/7303cc72    #2380   +/-   ##
==================================================
  Coverage              68.31%   68.32%           
==================================================
  Files                    357      357           
  Lines                  47159    47154    -5     
==================================================
  Hits                   32217    32217           
+ Misses                 14942    14937    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Larkooo Larkooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but we just need to do more tests to verify if this behaviour both works on pathfinder & katana

@lambda-0x
Copy link
Collaborator Author

yup tested locally and also confirmed with @kariy

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thing, will be even better when switching to getEvents even for pending block. :)

@lambda-0x
Copy link
Collaborator Author

Closing pull request: commit has gone away

@lambda-0x lambda-0x closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants