-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt(torii): fetch receipts along with blocks instead of fetching them individually #2380
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spr/main/7303cc72 #2380 +/- ##
==================================================
Coverage 68.31% 68.32%
==================================================
Files 357 357
Lines 47159 47154 -5
==================================================
Hits 32217 32217
+ Misses 14942 14937 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but we just need to do more tests to verify if this behaviour both works on pathfinder & katana
yup tested locally and also confirmed with @kariy |
6ebd806
to
c0397ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thing, will be even better when switching to getEvents
even for pending block. :)
c0397ff
to
c740651
Compare
… individually commit-id:b6db4cb5
c740651
to
8c6b5d0
Compare
4e78c46
to
d8ab387
Compare
Closing pull request: commit has gone away |
Stack: