Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3902 : allow double click in image picker #3914

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

eszkadev
Copy link
Contributor

Steps to reproduce the behavior:

  1. Open any document in Nextcloud Office
  2. Insert -> Insert Image... (it shows NC file picker)
  3. Double click on any entry (or even anywhere in the dialog?)
  4. Click button 'Insert Image'

Result: no image inserted, in the browser console we can see error:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'path')

Steps to reproduce the behavior:

1. Open any document in Nextcloud Office
2. Insert -> Insert Image... (it shows NC file picker)
3. Double click on any entry (or even anywhere in the dialog?)
4. Click button 'Insert Image'

Result: no image inserted, in the browser console we can see error:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'path')

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
@elzody
Copy link
Contributor

elzody commented Aug 19, 2024

/backport to stable30

@elzody
Copy link
Contributor

elzody commented Aug 19, 2024

/backport to stable29

@elzody elzody merged commit 4874ec3 into nextcloud:main Aug 19, 2024
52 checks passed
@juliushaertl juliushaertl added the bug Something isn't working label Aug 20, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants